Similar to D18206.
The Splash Screen KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it and makes some other improvements.
Details
Details
- Reviewers
davidedmundson ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
- Commits
- R119:fd94db08a555: Improve the Splash Screen KCM
Open the Splash Screen KCM
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kcms/ksplash/kcm_splashscreen.desktop | ||
|---|---|---|
| 2 | I know you're making this change because we don't actually have a preferences-system-splash icon, but is this really semantically correct? It seems like we should actually create that icon, or maybe make preferences-system-login a symlink to it for now. Of course that's a frameworks change, so it wouldn't get done in time for the Plasma 5.15 release... | |
| kcms/ksplash/kcm_splashscreen.desktop | ||
|---|---|---|
| 2 | Yes, I just used it because I think it should be included in Plasma 5.15 and it is the closest to a login splash icon I could find. | |
| kcms/ksplash/kcm_splashscreen.desktop | ||
|---|---|---|
| 2 | BTW, the Plymouth Splash KCM just uses an empty screen icon. | |
| kcms/ksplash/kcm_splashscreen.desktop | ||
|---|---|---|
| 2 |
It would be a runtime change, so if you got it in next frameworks it'd fix itself midway through Plasma 5.15 beta. No need to do a workaround. | |
| kcms/ksplash/kcm_splashscreen.desktop | ||
|---|---|---|
| 2 | Quite right. Let's revert the icon change in this patch and either create an appropriate icon or make it a symlink to preferences-system-login in breeze-icons. | |
Comment Actions
In general, you should wait until all reviewers with an open "Changes Requested" status have changed it to "Accepted" before landing a patch.