Adjust our Timer Fix
ClosedPublic

Authored by rizzitello on Jan 15 2019, 3:23 PM.

Details

Summary

Diff Detail

Repository
R232 AtCore
Branch
fixTimerPulse
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7148
Build 7166: arc lint + arc unit
rizzitello requested review of this revision.Jan 15 2019, 3:23 PM
rizzitello created this revision.
rizzitello retitled this revision from Summary: - Revert "More consistant emits on timer changes" Its the wrong fix This reverts commit a1a7c4a73ffb8291d60bd2fee28c59e0fb84f585, reversing changes made to 3e77c108d560c0c214bb685d49c68a48479ee940. - Set timer interval when changed to Adjust our Timer Fix.Jan 15 2019, 3:24 PM
rizzitello edited the summary of this revision. (Show Details)
rizzitello added a project: Atelier: AtCore.
rizzitello edited the summary of this revision. (Show Details)
rizzitello added a subscriber: Atelier: AtCore.
laysrodrigues accepted this revision.Jan 15 2019, 4:18 PM
This revision is now accepted and ready to land.Jan 15 2019, 4:18 PM
patrickelectric requested changes to this revision.Jan 15 2019, 9:12 PM
patrickelectric added inline comments.
src/core/atcore.cpp
322–326

if (newTime == 0 && timer.isRunning())

This revision now requires changes to proceed.Jan 15 2019, 9:12 PM
rizzitello updated this revision to Diff 49576.Jan 15 2019, 9:37 PM
  • Following patrick' suggestion, ensure timer is running before stopping it
rizzitello marked an inline comment as done.Jan 15 2019, 9:38 PM
rizzitello edited the summary of this revision. (Show Details)
patrickelectric accepted this revision.Jan 15 2019, 10:08 PM
This revision is now accepted and ready to land.Jan 15 2019, 10:08 PM
patrickelectric requested changes to this revision.Jan 15 2019, 10:08 PM
This revision now requires changes to proceed.Jan 15 2019, 10:08 PM
patrickelectric accepted this revision.Jan 15 2019, 10:11 PM
This revision is now accepted and ready to land.Jan 15 2019, 10:11 PM
rizzitello closed this revision.Jan 16 2019, 2:14 PM