Improve the Cursor Theme KCM
ClosedPublic
Actions

Authored by GB_2 on Jan 15 2019, 3:01 PM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Maniphest Tasks

T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible

Commits

R119:e0a4d3fa415d: Improve the Cursor Theme KCM

Summary

Similar to D18206.
The Cursor Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it and makes some other improvements.

Test Plan

Open the Cursor Theme KCM

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

GB_2 created this revision.Jan 15 2019, 3:01 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 15 2019, 3:01 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

GB_2 requested review of this revision.Jan 15 2019, 3:01 PM

Harbormaster completed remote builds in B7126: Diff 49536.Jan 15 2019, 3:01 PM

Try to stick to titles that aren't "improve" as that literally covers every patch (or at least, you'd hope so)

kcms/cursortheme/package/metadata.desktop
63	Where is this string visible?

ngraham accepted this revision.Jan 15 2019, 3:18 PM

ngraham added a subscriber: ngraham.

ngraham added inline comments.

kcms/cursortheme/package/metadata.desktop
63	In the tooltip and header on the page. Or at least, this should be consistent with the `Comment` in `kcm_cursortheme.desktop`.

This revision is now accepted and ready to land.Jan 15 2019, 3:18 PM

In D18267#393604, @davidedmundson wrote:

Try to stick to titles that aren't "improve" as that literally covers every patch (or at least, you'd hope so)

Ok, there is one more patch that I will make with this name though, since I already used this name and description for the other ones too.

kcms/cursortheme/package/metadata.desktop
63	In the description of the KCM when you hover over it.

GB_2 edited the summary of this revision. (Show Details)Jan 15 2019, 3:23 PM

In the tooltip and header on the page

In the description of the KCM when you hover over it.

Both those are taken from kcm_cursortheme.desktop surely.

In D18267#393620, @davidedmundson wrote:

In the tooltip and header on the page

In the description of the KCM when you hover over it.

Both those are taken from kcm_cursortheme.desktop surely.

Yeah, but if we change it there, we should make sure that metadata.desktop is updated too, right?

In D18267#393635, @ngraham wrote:

In D18267#393620, @davidedmundson wrote:

In the tooltip and header on the page

In the description of the KCM when you hover over it.

Both those are taken from kcm_cursortheme.desktop surely.

Yeah, but if we change it there, we should make sure that metadata.desktop is updated too, right?

Yes, this also wasn't a problem with the other patches.

Closed by commit R119:e0a4d3fa415d: Improve the Cursor Theme KCM (authored by GB_2). · Explain WhyJan 15 2019, 3:40 PM

This revision was automatically updated to reflect the committed changes.

GB_2 added a task: T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible.Feb 9 2019, 5:14 PM

Revision Contents
Changeset List

			Path	Packages
M			kcms/cursortheme/kcm_cursortheme.desktop (4 lines)
M			kcms/cursortheme/kcmcursortheme.cpp (4 lines)
M			kcms/cursortheme/package/contents/ui/main.qml (2 lines)
M			kcms/cursortheme/package/metadata.desktop (4 lines)