the Lookand Feel kcm already applies decorations to kwin, allow to
read them as defaults for the case of distribution customization
where a different lnf with a different deco is wanted
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma KWin - Commits
- R108:23dc03f734b1: support decorations from lookandfeel
tested to start kwin with a different lnf which loads an aurorae decoration
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- phab/lnf
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 7121 Build 7139: arc lint + arc unit
Comment Actions
Generally makes sense.
Minor nitpicks, but otherwise +1
In your commit message:
s/kein/kwin
decorations/decorationbridge.cpp | ||
---|---|---|
85–88 | This local var is effectively unused. It'll be clearer if the last line just uses s_defaultPlugin directly I would also avoid "cg" because kwinApp->config() is also a cg. This also applies for readTheme |
decorations/decorationbridge.cpp | ||
---|---|---|
85–88 | maybe by rewriting s_defaultTheme in the DecorationBridge ctor? |