support decorations from lookandfeel
ClosedPublic

Authored by mart on Jan 15 2019, 12:34 PM.

Details

Summary

the Lookand Feel kcm already applies decorations to kwin, allow to
read them as defaults for the case of distribution customization
where a different lnf with a different deco is wanted

Test Plan

tested to start kwin with a different lnf which loads an aurorae decoration

Diff Detail

Repository
R108 KWin
Branch
phab/lnf
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7121
Build 7139: arc lint + arc unit
mart created this revision.Jan 15 2019, 12:34 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 15 2019, 12:34 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
mart requested review of this revision.Jan 15 2019, 12:34 PM

Generally makes sense.
Minor nitpicks, but otherwise +1

In your commit message:
s/kein/kwin

decorations/decorationbridge.cpp
85–88

This local var is effectively unused.
"plugin" isn't a very helpful name as there are 3 potential plugins mentioned in this method.

It'll be clearer if the last line just uses s_defaultPlugin directly

I would also avoid "cg" because kwinApp->config() is also a cg.

This also applies for readTheme

mart edited the test plan for this revision. (Show Details)Jan 15 2019, 1:10 PM
mart added inline comments.
decorations/decorationbridge.cpp
85–88

maybe by rewriting s_defaultTheme in the DecorationBridge ctor?

mart updated this revision to Diff 49528.Jan 15 2019, 2:07 PM
  • don't use useless vars
davidedmundson accepted this revision.Jan 16 2019, 12:34 AM
This revision is now accepted and ready to land.Jan 16 2019, 12:34 AM
This revision was automatically updated to reflect the committed changes.