This patch improves the up/down display for the Monitor widgets
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma VDG - Commits
- R120:64045dbddc14: Improve up/down display for Monitor widgets
Before, no activity:
After, no activity:
Before, some activity:
After, some activity:
All the other ones still look good or are improved:
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| applets/systemmonitor/common/contents/ui/DoublePlotter.qml | ||
|---|---|---|
| 105–109 | Can we assume a font has ⬆ characters? | |
| applets/systemmonitor/common/contents/ui/DoublePlotter.qml | ||
|---|---|---|
| 105–109 | I grabbed this code from plasma-nm, which does the same thing. I haven't heard any complaints about that so I'm going to assume yes? | |
Comment Actions
Seems like the original change to use bits (D4551) was not super popular and generated bug reports (https://bugs.kde.org/show_bug.cgi?id=383019). If/when this lands, I'll look into making the unit configurable, since I can see the logic for both of them.
Comment Actions
I grabbed this code from plasma-nm, which does the same thing.
Ok, cool. Ship that part.
As for the other change. Right now it's in JDEC - you're porting to IEC. Both are valid.
SI would be wrong, but that would be k not K.
If you are going to add an option lets do it properly via a formatSpeed in KCoreAddons::KFormat method.
Comment Actions
Landing based on @davidedmundson's "ship it" for what's left (I think he's asleep right now and I'd like to get this in before we branch). Will submit further patches for other changes.