Differential D18248

Guard resource deletion in OuptutConfiguration::sendApplied
ClosedPublic
Actions

Authored by davidedmundson on Jan 14 2019, 4:08 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R127:9b0a3dcfeae0: Guard resource deletion in OuptutConfiguration::sendApplied
Summary

A client (kscreen-doctor especially) can disconnect whilst kwin still
has an instance.

Test Plan

Had reproducible crash on kscreen-doctor.
Now don't.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 14 2019, 4:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 14 2019, 4:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 14 2019, 4:08 PM
zzag added a subscriber: zzag.Jan 14 2019, 4:51 PM

If I understand it correctly, KWin tries to notify whether the changes have been applied successfully after the interface was unbound, but before OutputConfigurationInterface object is deleted, is it correct? (sorry if that's a stupid question)

zzag accepted this revision.Jan 14 2019, 4:55 PM

OK, makes sense.

This revision is now accepted and ready to land.Jan 14 2019, 4:55 PM
Closed by commit R127:9b0a3dcfeae0: Guard resource deletion in OuptutConfiguration::sendApplied (authored by davidedmundson). · Explain WhyJan 14 2019, 5:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 49465

View Options

src/server/outputconfiguration_interface.cpp

Loading...