Improve Desktop/Plasma Theme KCM
ClosedPublic

Authored by GB_2 on Jan 14 2019, 3:59 PM.

Details

Summary

Similar to D18206.
The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and renames the KCM to "Plasma Theme".

Test Plan

Open the Desktop/Plasma Theme KCM

Diff Detail

Repository
R119 Plasma Desktop
Branch
improve-desktoptheme-kcm (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7089
Build 7107: arc lint + arc unit
GB_2 created this revision.Jan 14 2019, 3:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 14 2019, 3:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Jan 14 2019, 3:59 PM

The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and

Where?

renames the KCM to "Plasma Theme".

I can only see this.

GB_2 added a comment.EditedJan 14 2019, 4:08 PM

The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it, makes some other improvements and

Where?

renames the KCM to "Plasma Theme".

I can only see this.

Wrong description, icon and text capitalization.
Also see here: https://phabricator.kde.org/T10273

ngraham accepted this revision.Jan 14 2019, 4:17 PM
ngraham added a subscriber: ngraham.

+1. The only change here that I think might be remotely controversial is changing "Desktop theme" to Plasma theme". But I thin that's a very good change since it improves the ability to understand what this actually is, and also uses our branding. You're using Plasma, so this thing chooses the Plasma theme. Makes sense to me.

This revision is now accepted and ready to land.Jan 14 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.