login screen with same behavior as lockscreen
Needs RevisionPublic

Authored by mart on Jan 14 2019, 9:58 AM.


Group Reviewers

start with wallpaper only mode by default, blur background at first
Note that there are no visual changes at all, just starts in wallpaper mode

Test Plan

works as before, just starts in wallaper mode which before was triggered after waiting for 60

Diff Detail

R120 Plasma Workspace
No Linters Available
No Unit Test Coverage
Build Status
Buildable 7074
Build 7092: arc lint + arc unit
mart created this revision.Jan 14 2019, 9:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 14 2019, 9:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Jan 14 2019, 9:58 AM
mart edited the summary of this revision. (Show Details)Jan 14 2019, 9:59 AM

Code is fine and I don't have any objections to doing this.

Will let VDG approve or not.

ngraham requested changes to this revision.Jan 14 2019, 2:43 PM
ngraham added a subscriber: ngraham.

I'm not sold on this for multiple reasons:

  1. It's very close to 5.15; I don't thing we should be making consequential UI changes to a controversial component three days before tagging.
  2. Due to limitations of the current design, this will just exchange one problem (people can't see the pretty login screen wallpaper) for others (people get confused by the lack of a visible UI; people get frustrated by the UI disappearing before they've made a choice, etc.)
  3. I'm not sure the "no controls are visible before user interaction" UI makes sense for a login screen. I tolerated it for the lock screen because there's only ever one user there, so immediately typing the password is a learnable habit, but the login screen incorporates a user switcher and there are more interactive possibilities. Furthermore, having there be basically no UI visible after you start up your computer just doesn't seem user-friendly to me. Sure, over time, people would get used to it, but is is really an improvement? I don't think so. GNOME has this type of design for their login screen and I find it really unfriendly and annoying there.

VDG's opinions these days are that the basic design needs to be looked at in the 5.16 timeframe, because with the current design we have no room to maneuver: every time we change one thing it regresses something else. That's a sign that the design isn't accommodating our needs anymore. See T10325: 5.16 Login screen improvements


Seems unrelated?

This revision now requires changes to proceed.Jan 14 2019, 2:43 PM
abetts added a subscriber: abetts.Jan 14 2019, 3:08 PM

I agree with @ngraham here. I feel that it is not always wise to apply the same UX everywhere. It might feel right but there are user experiences that are common place for other systems and it could become distracting for the user to expect one thing and such thing behaves too much outside of that expectation.