Differential D18233

Set XDG_SESSION_TYPE=wayland in startplasmacompositor
ClosedPublic
Actions

Authored by fvogt on Jan 13 2019, 8:17 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:65e3cc3a58ce: Set XDG_SESSION_TYPE=wayland in startplasmacompositor
Summary

KWorkSpace::detectPlatform among others use that, so make sure it's set.

On 5.12 it has export QT_QPA_PLATFORM=wayland already, so it's not necessary (?).

Test Plan

I had that patch applied locally for basically ever, works fine.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7062
Build 7080: arc lint + arc unit
fvogt created this revision.Jan 13 2019, 8:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 13 2019, 8:17 PM
fvogt requested review of this revision.Jan 13 2019, 8:17 PM
davidedmundson added a subscriber: davidedmundson.Jan 13 2019, 9:16 PM

The login manager should set this already

fvogt added a comment.Jan 13 2019, 9:19 PM

The login manager should set this already

If no display manager is used it's unset, which causes weird issues.

davidedmundson accepted this revision.Jan 13 2019, 9:50 PM
This revision is now accepted and ready to land.Jan 13 2019, 9:50 PM
Closed by commit R120:65e3cc3a58ce: Set XDG_SESSION_TYPE=wayland in startplasmacompositor (authored by fvogt). · Explain WhyJan 13 2019, 10:04 PM
This revision was automatically updated to reflect the committed changes.
zzag added a subscriber: zzag.Jan 13 2019, 10:05 PM

We should probably update https://community.kde.org/KWin/Wayland as well.

fvogt added a comment.Jan 13 2019, 10:09 PM
In D18233#392685, @zzag wrote:

We should probably update https://community.kde.org/KWin/Wayland as well.

I updated the tty section now.

zzag added a comment.Jan 13 2019, 10:11 PM
In D18233#392688, @fvogt wrote:

I updated the tty section now.

Cool! Thanks. :-)

Revision Contents
Changeset List

Diff 49409

View Options

startkde/startplasmacompositor.cmake

Loading...