Differential D18231

[WIP] Detach for terminatorStyleTabs
ClosedPublic
Actions

Authored by maciejn on Jan 13 2019, 7:00 PM.

Details

Reviewers

tcanabrava

Summary

Fix to bring back detach for terminatorStyleTabs

detach single terminal works
detach tab works

need to fix some crashes and move tab

Diff Detail

Repository

R319 Konsole

Branch

terminatorStyleTabs

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7060
Build 7078: arc lint + arc unit

maciejn created this revision.Jan 13 2019, 7:00 PM

Restricted Application added a project: Konsole. · View Herald TranscriptJan 13 2019, 7:00 PM

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

maciejn requested review of this revision.Jan 13 2019, 7:00 PM

Harbormaster completed remote builds in B7060: Diff 49404.Jan 13 2019, 7:00 PM

maciejn retitled this revision from detach single terminal to [WIP] Detach for terminatorStyleTabs.Jan 13 2019, 7:03 PM

maciejn edited the summary of this revision. (Show Details)

maciejn added a reviewer: tcanabrava.

maciejn edited the summary of this revision. (Show Details)Jan 13 2019, 7:22 PM

that's awesome work, I merged in my local branch.
I belive with this we can request for a real review, as most of the things that are needed are finished.

tcanabrava accepted this revision.Jan 14 2019, 10:50 AM

This revision is now accepted and ready to land.Jan 14 2019, 10:50 AM

Merged at my local branch.

Revision Contents
Changeset List

			Path	Packages
M			src/Application.h (2 lines)
M			src/Application.cpp (25 lines)
M			src/MainWindow.h (2 lines)
M			src/MainWindow.cpp (2 lines)
M			src/ViewContainer.h (4 lines)
M			src/ViewContainer.cpp (40 lines)
M			src/ViewManager.h (5 lines)
M			src/ViewManager.cpp (44 lines)
M			src/ViewSplitter.h (7 lines)
M			src/ViewSplitter.cpp (19 lines)

Commit	Tree	Parents	Author	Summary	Date
a55a13f4cd85	c22c7b055298	da7d061f9b21	keredin	initial detach tab	Jan 13 2019, 6:56 PM
da7d061f9b21	4eb1ec37244b	9d42111f562d	keredin	detach single terminal	Jan 13 2019, 3:27 PM