Improve the Look and Feel KCM

Authored by GB_2 on Jan 12 2019, 12:33 PM.



The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so this fixes it and makes some other improvements.

Test Plan

Open the LnF KCM

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Jan 12 2019, 12:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2019, 12:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Jan 12 2019, 12:33 PM
GB_2 edited the summary of this revision. (Show Details)Jan 12 2019, 12:34 PM
filipf added a subscriber: filipf.Jan 12 2019, 4:15 PM

I like this because the essence of what the user is doing in this kcm is choosing, rather than configuring.

rooty added a subscriber: rooty.EditedJan 12 2019, 5:37 PM

+1 from me
if you want you could drop the article by the way and make it "Choose Look and Feel Theme"
it's like "Configure Network Settings" vs "Configure the Network Settings"

ngraham accepted this revision.Jan 12 2019, 5:50 PM
ngraham added a subscriber: ngraham.


I think the use of an article is okay here since it's basically a tooltip that just happens to be inappropriately displayed as a title for other reasons.

All those +1s add up to a formal acceptance, methinks.

This revision is now accepted and ready to land.Jan 12 2019, 5:50 PM
This revision was automatically updated to reflect the committed changes.