Add Kotlin (.kt) mimetype icons
ClosedPublic

Authored by trickyricky26 on Jan 11 2019, 8:13 PM.

Details

Summary

FEATURE: 401299

FIXED-IN: 5.54

Add an icon for Kotlin files (.kt).

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Branch
add-kotlin-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7042
Build 7060: arc lint + arc unit
trickyricky26 created this revision.Jan 11 2019, 8:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 11 2019, 8:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Jan 11 2019, 8:13 PM
ngraham added a reviewer: VDG.Jan 11 2019, 9:27 PM
ngraham added a subscriber: ngraham.

Pretty pictures? :) As discussed in chat, you'll need to submit a merge request to add support in shared-mime-info too.

Here is a commit where someone else added a new mimetype: https://gitlab.freedesktop.org/xdg/shared-mime-info/commit/7dea7e65c4f6872d70d1b17141caa11196e6405b

Hopefully you can use that as a template/inspiration for yours.

trickyricky26 edited the summary of this revision. (Show Details)Jan 11 2019, 9:39 PM
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 edited the summary of this revision. (Show Details)
  • Use a lighter color for 16px and 22px
trickyricky26 edited the test plan for this revision. (Show Details)Jan 11 2019, 10:58 PM
trickyricky26 updated this revision to Diff 49353.EditedJan 12 2019, 8:36 PM
  • Use a nicer purple color suggested by @alex-l, similar to the official logo:

trickyricky26 edited the test plan for this revision. (Show Details)Jan 12 2019, 8:36 PM
trickyricky26 added a subscriber: alex-l.
ngraham accepted this revision.Jan 12 2019, 10:34 PM

That's much better! I like the subtle gradient.

VDG folks, is everyone else good with this?

This revision is now accepted and ready to land.Jan 12 2019, 10:34 PM
trickyricky26 planned changes to this revision.Jan 12 2019, 10:46 PM

I'm going to add the gradient to the 32px as well

  • Use the gradient on the 32px version as well
This revision is now accepted and ready to land.Jan 13 2019, 1:00 PM
trickyricky26 edited the test plan for this revision. (Show Details)Jan 13 2019, 1:01 PM
ngraham accepted this revision.Jan 13 2019, 3:06 PM
ndavis accepted this revision.Jan 13 2019, 3:07 PM
This revision was automatically updated to reflect the committed changes.