Railroad activity OK button position fixed
Needs ReviewPublic

Authored by dekumar on Fri, Jan 11, 6:20 PM.

Details

Reviewers
None
Group Reviewers
GCompris: Improvements
Summary

Ok button position fixed

Diff Detail

Repository
R2 GCompris
Branch
rail
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6978
Build 6996: arc lint + arc unit
dekumar created this revision.Fri, Jan 11, 6:20 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFri, Jan 11, 6:20 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
dekumar requested review of this revision.Fri, Jan 11, 6:20 PM
dekumar retitled this revision from core, fix tutorial loader enability to Railroad activity OK button position fixed.Fri, Jan 11, 6:22 PM
dekumar added a reviewer: GCompris: Improvements.

I'm not sure to understand this change. What does it fix? I now see the OK button more on the left of the score but I don' see which overriding it's supposed to fix

@jjazeix The OK button was overriding the house .You may have a look over this https://pasteboard.co/HWRy8AK.png

@jjazeix The OK button was overriding the house .You may have a look over this https://pasteboard.co/HWRy8AK.png

But with the fix, it overrides the train station. Both are just background elements, so if there is really an issue, we can just remove the house.
@timotheegiet should we remove the house? I, personally, don't think it's useful to remove it.

Indeed the images on the top are just decorations; also the position of the image is fixed on purpose, making the part under the OK button changing depending on the screen/window size.
So, we don't need to move the ok button at all, this possible overriding is part of the design.