It wasn't working at all
Details
Details
Diff Detail
Diff Detail
- Repository
- R858 Qt Quick Controls 2: Desktop Style
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I'm finding issues with combobox and this patch.
Using the test supplied I can't select other items.
| org.kde.desktop/ComboBox.qml | ||
|---|---|---|
| 207 | Breaking it down it's this one line that causes major regressions for me though I can't immediately see why. Can you elaborate on what was broken and why you changed it? | |
| org.kde.desktop/ComboBox.qml | ||
|---|---|---|
| 207 | delegateModel property doesn't exist in QQC2.ComboBox. I was never getting a popup. http://doc.qt.io/qt-5/qml-qtquick-controls-combobox-members.html Also we didn't use to specify a delegate to the ListView | |
Comment Actions
I gave it a test and indeed selecting also needs looking into. I guess I just didn't fully fix it.
| org.kde.desktop/ComboBox.qml | ||
|---|---|---|
| 207 | The docs you were looking at are QQC1. Q_PROPERTY(QQmlInstanceModel *delegateModel READ delegateModel NOTIFY delegateModelChanged FINAL)``` is in `QtQuick.Templates` `ComboBox`, which this thing is. | |