Fix ComboBox
AcceptedPublic

Authored by apol on Fri, Jan 11, 4:46 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R858:4f00b0cabc12: Fix ComboBox
Summary

It wasn't working at all

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Fri, Jan 11, 4:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jan 11, 4:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Fri, Jan 11, 4:46 PM
mart accepted this revision.Fri, Jan 11, 6:47 PM
This revision is now accepted and ready to land.Fri, Jan 11, 6:47 PM
This revision was automatically updated to reflect the committed changes.

I'm finding issues with combobox and this patch.

Using the test supplied I can't select other items.

davidedmundson added inline comments.Wed, Jan 16, 1:42 PM
org.kde.desktop/ComboBox.qml
207

Breaking it down it's this one line that causes major regressions for me though I can't immediately see why.

Can you elaborate on what was broken and why you changed it?

apol added inline comments.Wed, Jan 16, 2:46 PM
org.kde.desktop/ComboBox.qml
207

delegateModel property doesn't exist in QQC2.ComboBox. I was never getting a popup.

http://doc.qt.io/qt-5/qml-qtquick-controls-combobox-members.html

Also we didn't use to specify a delegate to the ListView

apol added a comment.Wed, Jan 16, 2:52 PM

I gave it a test and indeed selecting also needs looking into. I guess I just didn't fully fix it.

broulik reopened this revision.Thu, Jan 17, 1:40 PM
broulik added a subscriber: broulik.

This breaks mouse wheel interaction

This revision is now accepted and ready to land.Thu, Jan 17, 1:40 PM
broulik added inline comments.Thu, Jan 17, 1:43 PM
org.kde.desktop/ComboBox.qml
207

The docs you were looking at are QQC1.

Q_PROPERTY(QQmlInstanceModel *delegateModel READ delegateModel NOTIFY delegateModelChanged FINAL)``` is in `QtQuick.Templates` `ComboBox`, which this thing is.