Differential D18177

Manual added for letter in which word activity
ClosedPublic
Actions

Authored by dekumar on Jan 11 2019, 8:11 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Improvements
Summary

Manual added

Diff Detail

Repository
R2 GCompris
Branch
letter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6946
Build 6964: arc lint + arc unit
dekumar created this revision.Jan 11 2019, 8:11 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 11 2019, 8:11 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
dekumar requested review of this revision.Jan 11 2019, 8:11 AM
dekumar retitled this revision from core, fix tutorial loader enability to Manual added for letter in which word activity.Jan 11 2019, 8:12 AM
dekumar added a reviewer: GCompris: Improvements.
jjazeix added a subscriber: jjazeix.EditedJan 11 2019, 8:58 AM

except these small changes, it's good for me, I'll merge them once I can

src/activities/letter-in-word/ActivityInfo.qml
36

"Attached to".
for tablets/phones there is no mouse. Prefer "click or tap".

src/core/Tutorial.qml
51

These changes should not appear as they are already in master.
Rebasing your branch on master should fix this.

dekumar marked an inline comment as done.Jan 11 2019, 9:15 AM
This comment was removed by dekumar.
dekumar updated this revision to Diff 49219.Jan 11 2019, 9:15 AM
  • Typo fixed
dekumar updated this revision to Diff 49221.Jan 11 2019, 9:42 AM
This comment was removed by dekumar.
This revision is now accepted and ready to land.Jan 11 2019, 4:22 PM
jjazeix closed this revision.Jan 11 2019, 4:22 PM

Revision Contents
Changeset List

Diff 49221

View Options

src/activities/letter-in-word/ActivityInfo.qml

Loading...
View Options

src/core/Tutorial.qml

Loading...