Differential D18170

Overhaul right drawer's UI
ClosedPublic
Actions

Authored by ngraham on Jan 10 2019, 8:43 PM.

Details

Reviewers
apol
GB_2
Group Reviewers
VDG
Commits
R474:6704bdd96180: Overhaul right drawer's UI
Summary

The right drawer's UI was nonstandard and violated numerous HIG guidelines. This
patch fixes that by doing the following:

  • Move the configuration settings to a new page on the stack
  • Make the picture/video directory choosers use a common and comprehensible UI
  • Don't ask for confirmation before moving items to the trash
  • Disable rather than hide inapplicable actions
  • Give the back buttons arrows
  • Display an informative message when there are no pictures to show
  • Fix ellipsis use
  • Use correct casing for titles and buttons
  • Improve button title formatting and use i18np() where appropriate
  • Port a few deprecated uses of Kirigami.Label to the QQC2 version
  • Improve header text margins
Test Plan

Before:

After:

New message when no Kamoso-taken images are in the current pictures directory:

New Configuration page:

Diff Detail

Repository
R474 Kamoso
Branch
right-drawer-ui-overhaul (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6977
Build 6995: arc lint + arc unit
ngraham requested review of this revision.Jan 10 2019, 8:43 PM
ngraham updated this revision to Diff 49200.
ngraham created this revision.

Fix one capitalization issue I missed

ngraham edited the test plan for this revision. (Show Details)Jan 10 2019, 8:46 PM
ngraham edited the summary of this revision. (Show Details)Jan 10 2019, 8:51 PM
GB_2 added a subscriber: GB_2.Jan 10 2019, 9:43 PM

Looks great! One suggestion though, could you please change the "Choose..." button to the icon document-open and no text, but a tooltip saying "Open file dialog" or "Choose folder" to make it consistent with other programs?

apol accepted this revision.Jan 11 2019, 1:23 PM
This revision is now accepted and ready to land.Jan 11 2019, 1:23 PM
ngraham updated this revision to Diff 49247.Jan 11 2019, 3:46 PM

Use a more conventional UI for the directory choosers

ngraham edited the test plan for this revision. (Show Details)Jan 11 2019, 3:47 PM

No tooltip for now since I can't seem to get it to work. Will follow up in another patch.

ngraham updated this revision to Diff 49273.Jan 11 2019, 6:12 PM

Add tooltips to the icons-only buttons on the configure page

ngraham edited the summary of this revision. (Show Details)Jan 11 2019, 6:14 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 49284.Jan 11 2019, 7:32 PM

Correct capitalization for one Item

GB_2 accepted this revision.Jan 11 2019, 7:35 PM

Nice!

Closed by commit R474:6704bdd96180: Overhaul right drawer's UI (authored by ngraham). · Explain WhyJan 11 2019, 7:48 PM
This revision was automatically updated to reflect the committed changes.
broulik reopened this revision.Jan 16 2019, 12:51 PM
broulik added a subscriber: broulik.
broulik added inline comments.
src/qml/ImagesView.qml
4–5

This bumps the requirement to Qt 5.12, please check whether you really need any new feature from that or revert this change.

This revision is now accepted and ready to land.Jan 16 2019, 12:51 PM
ngraham closed this revision.Jan 16 2019, 9:37 PM
ngraham marked an inline comment as done.
ngraham added inline comments.
src/qml/ImagesView.qml
4–5

Sorry about that. Fixed in https://cgit.kde.org/kamoso.git/commit/?id=2c32161d61866413289427cd475afc7b5e101869.

Revision Contents
Changeset List

PathPackages
Msrc/qml/ImagesView.qml (268 lines)

Diff 49273

View Options

src/qml/ImagesView.qml

Loading...