Differential D18152

Preset file name of archive in CreateDialog
ClosedPublic
Actions

Authored by volkov on Jan 10 2019, 12:09 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Ark
Commits
R36:233de9e97cb1: Preset file name of archive in CreateDialog
Summary

The file name can be set explicitly by --add-to option or
detected automatically with --add option. Set it in the
dialog for the convenience of users.

Diff Detail

Repository
R36 Ark
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6904
Build 6922: arc lint + arc unit
volkov created this revision.Jan 10 2019, 12:09 PM
Restricted Application added a project: Ark. · View Herald TranscriptJan 10 2019, 12:09 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
volkov requested review of this revision.Jan 10 2019, 12:09 PM
volkov added a reviewer: Ark.Jan 10 2019, 12:10 PM
elvisangelaccio added a subscriber: elvisangelaccio.Jan 13 2019, 12:15 PM
elvisangelaccio added inline comments.
kerfuffle/addtoarchive.cpp
102

Why this change? Is QFileInfo(m_filename).path() going to be different from m_firstPath ?

volkov added inline comments.Jan 14 2019, 11:06 AM
kerfuffle/addtoarchive.cpp
102

Yes, m_filename can be set with --add-to option.

elvisangelaccio accepted this revision.Feb 10 2019, 4:12 PM
This revision is now accepted and ready to land.Feb 10 2019, 4:12 PM
volkov closed this revision.Feb 11 2019, 10:44 AM

Revision Contents
Changeset List

Diff 49149

View Options

kerfuffle/addtoarchive.h

Loading...
View Options

kerfuffle/addtoarchive.cpp

Loading...
View Options

kerfuffle/createdialog.h

Loading...
View Options

kerfuffle/createdialog.cpp

Loading...