properly show xfreerdp runtime dependency in cmake summary
ClosedPublic

Authored by sitter on Thu, Jan 10, 11:39 AM.

Details

Summary

in absence of a proper finder we'll have a fake package find which we
force found depending on the find_program call.

this results in the runtime dep being reported as such in the cmake
feature summary

Test Plan

rm -rf *; cmake ..

  • executable found => reported found in summary
  • executable !found => reported !found

Diff Detail

Repository
R436 KRDC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Thu, Jan 10, 11:39 AM
sitter created this revision.
sitter added a subscriber: whiting.

somewhat unrelated ... @whiting do you recall why line 83 still says "Needs porting"? according to the git history you ported this a couple months after but the comment was not removed.

aacid added a subscriber: aacid.Thu, Jan 10, 7:34 PM
aacid added inline comments.
CMakeLists.txt
95

I know the binary name is xfreerdp, but it's not the name they use themselves on the web and and it's not the name of the package distributions have either, i'd be more confortable with freerdp, but feel free to disagree

sitter added inline comments.Fri, Jan 11, 9:18 AM
CMakeLists.txt
95

The motivation behind that was to communicate that we need that specific binary. As a compromise we could call the package freerdp and simply mention the binary in the PURPOSE I guess? That way we get both bits of information right.

sitter updated this revision to Diff 49229.Fri, Jan 11, 11:32 AM

rename the package to freerdp but explicitly mention that the xfreerdp binary is needed

aacid accepted this revision.Fri, Jan 11, 6:12 PM
This revision is now accepted and ready to land.Fri, Jan 11, 6:12 PM
This revision was automatically updated to reflect the committed changes.
sitter marked an inline comment as done.