Differential D18141

Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled
ClosedPublic
Actions

Authored by asturmlechner on Jan 9 2019, 10:30 PM.

Details

Reviewers
rahn
Group Reviewers
Marble
Commits
R34:599e962f7088: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled
Summary

Fixes at least a big cmake warning and potentially ppc64 build.

Test Plan

Builds fine with and without Qt5WebEngine.

Diff Detail

Repository
R34 Marble
Branch
Applications/18.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6884
Build 6902: arc lint + arc unit
asturmlechner created this revision.Jan 9 2019, 10:30 PM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptJan 9 2019, 10:30 PM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
asturmlechner requested review of this revision.Jan 9 2019, 10:30 PM
rahn accepted this revision.Feb 26 2019, 10:58 AM
rahn added a subscriber: rahn.

looks good

This revision is now accepted and ready to land.Feb 26 2019, 10:58 AM
Closed by commit R34:599e962f7088: Avoid overwriting Qt5_FOUND with Qt5DBus or Qt5WebEngine disabled (authored by asturmlechner). · Explain WhyMar 4 2019, 6:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (17 lines)

Diff 49117

View Options

CMakeLists.txt

Loading...