Differential D18139

GuessLanguage: Delete copy constructor and assignment operator
ClosedPublic
Actions

Authored by aacid on Jan 9 2019, 9:41 PM.

Details

Reviewers
vkrause
Commits
R246:9e13da51546f: GuessLanguage: Delete copy constructor and assignment operator
Summary

If someone was using them, it'd crash since it was raw-copying the d pointer
so you would end up with a double delete.

This is SIC, but IMHO it's fine, whoever gets a compiler failure has a bug to fix

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6881
Build 6899: arc lint + arc unit
aacid requested review of this revision.Jan 9 2019, 9:41 PM
aacid created this revision.
vkrause accepted this revision.Jan 10 2019, 7:41 PM
This revision is now accepted and ready to land.Jan 10 2019, 7:41 PM
aacid closed this revision.Jan 10 2019, 7:46 PM

Revision Contents
Changeset List

PathPackages
Msrc/core/guesslanguage.h (3 lines)

Diff 49114

View Options

src/core/guesslanguage.h

Loading...