[scripting] Avoid threading issues when loading from a file
ClosedPublic
Actions

Authored by davidedmundson on Jan 9 2019, 3:50 PM.

Details

Reviewers

graesslin

Group Reviewers

KWin

Commits

Summary

KWin::Script::loadScriptFromFile ran in it's own thread and accessed
member variables of KWin::Script without any guards.

Potentially script could be destroyed whilst the file is loading.

Rather than adding mutexes everywhere, this patch scopes the QFile
object to be local to the threaded function making it independent.

BUG: 403038

Test Plan

Ran a script from a file

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptJan 9 2019, 3:50 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Jan 9 2019, 3:50 PM

This revision is now accepted and ready to land.Jan 9 2019, 5:24 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			scripting/scripting.h (9 lines)
M			scripting/scripting.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49084	bbb67f2		Jan 9 2019, 3:50 PM	★	★
Diff 2	49120	fbe2191	R108:ba7aecfe53d765e0f94626ed00010a40284b99c0	Jan 9 2019, 11:37 PM	★	★