Differential D18126

[scripting] Avoid threading issues when loading from a file
ClosedPublic
Actions

Authored by davidedmundson on Jan 9 2019, 3:50 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:ba7aecfe53d7: [scripting] Avoid threading issues when loading from a file
Summary

KWin::Script::loadScriptFromFile ran in it's own thread and accessed
member variables of KWin::Script without any guards.

Potentially script could be destroyed whilst the file is loading.

Rather than adding mutexes everywhere, this patch scopes the QFile
object to be local to the threaded function making it independent.

BUG: 403038

Test Plan

Ran a script from a file

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6862
Build 6880: arc lint + arc unit
davidedmundson created this revision.Jan 9 2019, 3:50 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 9 2019, 3:50 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 9 2019, 3:50 PM
graesslin accepted this revision.Jan 9 2019, 5:24 PM
This revision is now accepted and ready to land.Jan 9 2019, 5:24 PM
Closed by commit R108:ba7aecfe53d7: [scripting] Avoid threading issues when loading from a file (authored by davidedmundson). · Explain WhyJan 9 2019, 11:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mscripting/scripting.h (9 lines)
Mscripting/scripting.cpp (16 lines)

Diff 49084

View Options

scripting/scripting.h

Loading...
View Options

scripting/scripting.cpp

Loading...