Remove dependency to AkonadiNotes and KMime

Authored by ervin on Jan 8 2019, 4:27 PM.



Keep the withNoteContent method in GenCollection and some of its use
though, it's useful in tests to simulate having collections containing
something else than tasks.

Diff Detail

R4 Zanshin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ervin requested review of this revision.Jan 8 2019, 4:27 PM
ervin created this revision.
dfaure added inline comments.Jan 8 2019, 9:54 PM

that makes it QStringLiteral, I thought this was a crash risk.

ervin updated this revision to Diff 49045.Jan 9 2019, 6:34 AM

Addresses David's comment.

Note it was likely harmless in this context since it's passed to a method
expecting a QString right away. But better safe than sorry indeed, we
don't know how that code or QString API might evolve in the future.

dfaure accepted this revision.Jan 9 2019, 7:52 AM
This revision is now accepted and ready to land.Jan 9 2019, 7:52 AM
This revision was automatically updated to reflect the committed changes.