Add new table layout unit tests
ClosedPublic

Authored by danders on Tue, Jan 8, 12:37 PM.

Details

Summary

Adds multiple areas capabilities and tests with merged cells

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders created this revision.Tue, Jan 8, 12:37 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptTue, Jan 8, 12:37 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
danders requested review of this revision.Tue, Jan 8, 12:37 PM

Not trivial (for me) to get data out of layout so it is hard to create robust tests.
I don't think I have been able to create a test to simulate the loop excactly.
Also, uncertain wether the MockRootAreaProvider is sufficient.
Any ideas/comments wellcome.

Looks like a good first start to me - do they pass currently? - if so then i think they should be pushed

I'll think about further tests

No, all do not pass, generally when the first row is merged, layout fails.
(I am trying to provoke problems similar to bug 381341 that we have tried to fix in D15428.)

danders updated this revision to Diff 49141.Thu, Jan 10, 10:16 AM

Add a test that trigger a loop in the table layout

Even if they do not all pass, I think they should be commited if the tests/methods are ok and the reason for not passing are genuin bugs, no?

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jan 15, 11:06 AM
This revision was automatically updated to reflect the committed changes.