Differential D18088

FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file
ClosedPublic
Actions

Authored by kossebau on Jan 7 2019, 11:55 PM.

Details

Reviewers
pino
apol
Group Reviewers
Frameworks
Commits
R240:ed985869924f: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file
Summary

Avoids to have manually set the property on the generated source file to
deal with changed CMake policy CMP0071.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jan 7 2019, 11:55 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptJan 7 2019, 11:55 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 7 2019, 11:55 PM
kossebau added a comment.Jan 7 2019, 11:56 PM

Not sure if there ever s a chance somebody would inject QObject code into such a generated file?

apol accepted this revision.Jan 8 2019, 12:46 AM
This revision is now accepted and ready to land.Jan 8 2019, 12:46 AM
Closed by commit R240:ed985869924f: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file (authored by kossebau). · Explain WhyJan 25 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mfind-modules/FindGperf.cmake (1 line)

Diff 50281

View Options

find-modules/FindGperf.cmake

Loading...