| aacid |
| KDE Applications |
Option "noWallet" was already supported in the code,
but was not visible in the configuration UI. This
option is useful on headless servers where you don't
really have a way to enter password to unlock the wallet.
CHANGELOG: Add an option to store passwords without using KDE Wallet
BUG: 397271
FIXED-IN: 19.04.0
Enable option, restart krfb, ensure that passwords are now in ~/.config/krfbrc. Disable option, restart krfb, see that passwords are no longer in krfbrc.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| krfb/ui/configsecurity.ui | ||
|---|---|---|
| 27 | This needs a big "YOUR PASSWORDS WILL BE STORED IN PLAIN TEXT IN THE CONFIG FILE" | |
To be precise, passwords are not stored as plain text, scrambled using KStringHandler::obscure(). But this is totally insecure anyway, is a wording like this OK?
I have not tried compiling not tried the code itself, but reading it i can't see anything wrong.
If you think this makes sense you're the closest thing we may have to a maintainer, so i'd say just go ahead and commit it.