Merge TaskApplicationComponents and ApplicationComponents
ClosedPublic
Actions

Authored by ervin on Jan 7 2019, 6:31 PM.

Details

Reviewers

bensi
dfaure

Commits

Summary

Again that distinction isn't necessary anymore.

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin requested review of this revision.Jan 7 2019, 6:31 PM

ervin created this revision.

What about that one? It's the only one holding up the push.

dfaure added inline comments.

src/widgets/applicationcomponents.cpp
172	wouldn't it be better to make m_runningTaskView mutable?

This revision is now accepted and ready to land.Jan 8 2019, 8:53 AM

src/widgets/applicationcomponents.cpp
172	Thought about that back then for the other members, my conclusion at the time was that I'd end up with almost all members mutable while there's only one place where I need them as such and would loose the constness safety everywhere else.

This revision was automatically updated to reflect the committed changes.

		Path
M		src/widgets/CMakeLists.txt (1 line)
M		src/widgets/applicationcomponents.h (10 lines)
M		src/widgets/applicationcomponents.cpp (37 lines)
D	M	src/widgets/taskapplicationcomponents.h (51 lines)
D	M	src/widgets/taskapplicationcomponents.cpp (66 lines)
M		src/zanshin/app/main.cpp (4 lines)
M		src/zanshin/kontact/part.cpp (4 lines)
M		tests/units/widgets/CMakeLists.txt (1 line)
M		tests/units/widgets/applicationcomponentstest.cpp (95 lines)
D	M	tests/units/widgets/taskapplicationcomponentstest.cpp (89 lines)