7834bec52a6770b16087be07a94cca6a165482a6 missed to port minimize and
unminimize to dynamic dispatch. In addition to that, we don't benefit
from QMetaObject::invokeMethod so port addRepaint and addLayerRepaint
to dynamic dispatch as well.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:ef7b553cb4e0: [libkwineffects] Port the remaining bits of API to dynamic dispatch
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- virtual-dispatch
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6754 Build 6772: arc lint + arc unit
Comment Actions
Technically that's an API break on kwin scripting as TopLevel is exposed there.
I can't think why any script would need them, but we made a point of documenting them: https://techbase.kde.org/Development/Tutorials/KWin/Scripting/API_4.9#Functions_4
Comment Actions
Another potential API break: making EffectWindow::closeWindow() non-const. Though I hope it would be okay to break compatibility there, it doesn't make sense to have that method const.
Comment Actions
missed to port minimize and unminimize to dynamic dispatch.
It wasn't exactly "missed", the commit description says it's porting all property getters as they were the only thing potentially called every frame.
But we may as well kill this moc-trampoline entirely. Ship it