[kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels
ClosedPublic
Actions

Authored by rooty on Jan 7 2019, 5:14 PM.

Details

Reviewers

kde-frameworks-devel
ngraham

Group Reviewers

VDG
Plasma

Maniphest Tasks

Commits

Summary

This patch removes the "Search:" portion of Activities (in System Settings, Desktop Behavior --> Workspace) and adds "Search..." to the search field.

Repository

R276 KItemViews

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

rooty requested review of this revision.Jan 7 2019, 5:14 PM

This has the effect of removing the search fields for all the shortcut chooser views. That doesn't seem like the intent here.

This revision now requires changes to proceed.Jan 8 2019, 1:39 AM

Fix blunder and bring back search field, place "Search..." in search field

Much better, thanks!

This revision is now accepted and ready to land.Jan 9 2019, 2:11 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/ktreewidgetsearchline.cpp (1 line)
M			src/ktreewidgetsearchlinewidget.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48876	f55982b		Jan 7 2019, 5:14 PM	★	★
Diff 2	49041	f55982b	Fix blunder and bring back search field, place "Search..." in search field	Jan 9 2019, 3:39 AM	★	★
Diff 3	49260	5279480	R276:649157422e4ea0a6bff0813bbcb718f63aeef60a	Jan 11 2019, 4:48 PM	★	★