Differential D1804

kcm_keyboard: Don't require libxcb-xinput
ClosedPublic
Actions

Authored by drosca on Jun 9 2016, 8:32 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R119:ca7618dd6173: kcm_keyboard: Don't require libxcb-xinput
Summary

Copying the definition of xcb_input_device_presence_notify_event_t to
our code makes the new device detection code work also on systems
without libxcb-xinput (Debian/Ubuntu).

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 4300.Jun 9 2016, 8:32 AM
drosca retitled this revision from to kcm_keyboard: Don't require libxcb-xinput.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 9 2016, 8:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Jun 9 2016, 9:01 AM

How can I test the code on my Debian system and confirm that it works as intended?

drosca added a comment.Jun 9 2016, 9:05 AM
In D1804#33497, @graesslin wrote:

How can I test the code on my Debian system and confirm that it works as intended?

Enable debug for org.kde.kcm_keyboard category, plug keyboard/mouse and look for "new keyboard/pointer device" in kded output.

graesslin added a comment.Jun 9 2016, 9:28 AM

output when plugging in a device:

kded5(3129)/(org.kde.kcm_keyboard) unknown: New device id: 10
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 2 name: Virtual core pointer used as: 0
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 3 name: Virtual core keyboard used as: 1
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 4 name: Virtual core XTEST pointer used as: 4
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 5 name: Virtual core XTEST keyboard used as: 3
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 6 name: Power Button used as: 3
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 7 name: Video Bus used as: 3
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 8 name: Power Button used as: 3
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 9 name: UVC Camera (046d:0825) used as: 3
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 11 name: Microsoft Microsoft® Nano Transceiver v2.1 used as: 3
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 12 name: Microsoft Microsoft® Nano Transceiver v2.1 used as: 4
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 13 name: Microsoft Microsoft® Nano Transceiver v2.1 used as: 4
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 14 name: Microsoft Microsoft® Nano Transceiver v2.1 used as: 3
kded5(3129)/(org.kde.kcm_keyboard) unknown: id: 10 name: Logitech M570 used as: 4
kded5(3129)/(org.kde.kcm_keyboard) unknown: new pointer device, id: 10 name: Logitech M570 used as: 4
drosca added a comment.Jun 9 2016, 9:30 AM

Great, so it works. Thanks for testing.

Should this go also to Plasma/5.6?

graesslin added a comment.Jun 9 2016, 9:32 AM
In D1804#33504, @drosca wrote:

Should this go also to Plasma/5.6?

I'd say better safe than sorry: master only

graesslin accepted this revision.Jun 9 2016, 9:37 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Jun 9 2016, 9:37 AM
Closed by commit R119:ca7618dd6173: kcm_keyboard: Don't require libxcb-xinput (authored by drosca). · Explain WhyJun 9 2016, 10:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4302

View Options

kcms/keyboard/CMakeLists.txt

Loading...
View Options

kcms/keyboard/xinput_helper.cpp

Loading...