Use a better icon for the "Shoot" action
ClosedPublic

Authored by ngraham on Jan 7 2019, 12:48 AM.

Details

Summary

The "Shoot" action right now displays a picture for an icon. This is a missed
opportunity to use a camera, which does a better job of communicating what the
action will actually do. We can also use an action from the icon theme and remove
one of the three custom icons we include, which the HIG recommends against doing
(https://hig.kde.org/style/icon.html#general-guidelines)

Test Plan

Diff Detail

Repository
R474 Kamoso
Branch
better-shoot-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6729
Build 6747: arc lint + arc unit
ngraham requested review of this revision.Jan 7 2019, 12:48 AM
ngraham created this revision.
ngraham edited the test plan for this revision. (Show Details)Jan 7 2019, 12:49 AM
apol accepted this revision.Jan 7 2019, 3:41 PM

Thanks!

This revision is now accepted and ready to land.Jan 7 2019, 3:41 PM
abetts added a subscriber: abetts.Jan 7 2019, 3:46 PM

+1

(May I suggest a visual preference? What if the buttons were black by default? I feel that because of their color, they seem odd for a control on a video camera. https://dribbble.com/shots/5673516-Day-32-Made-with-Studio is an example of what I mean. The controls are less obvious to leave the user to focus on the image they see)

The best part of this patch is your face :D

+1

(May I suggest a visual preference? What if the buttons were black by default?

The appearance here is 100% vanilla Kirigami for the mobile view, so you'd need to bring it up there.

The best part of this patch is your face :D

lol

This revision was automatically updated to reflect the committed changes.