Add All Top-Level Targets to the Menu
ClosedPublic

Authored by narvaez on Jan 6 2019, 10:48 PM.

Details

Summary

The previous code did not handle folders with
multiple actions but no parent.

Test Plan

Create a project with two toplevel targets (e.g.
a CMakeLists.txt with two add_executable calls), add the
project to a KDevelo session, go to Configure Launches and
try adding a compiled binary by clicking on the Add button
at the top-left corner. Before this patch, only one of the
two toplevel targets would show in the menu.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
narvaez created this revision.Jan 6 2019, 10:48 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJan 6 2019, 10:48 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
narvaez requested review of this revision.Jan 6 2019, 10:48 PM
arrowd added a subscriber: arrowd.Jan 7 2019, 7:47 AM
apol accepted this revision.Jan 8 2019, 3:53 PM
apol added a subscriber: apol.

Good catch!

This revision is now accepted and ready to land.Jan 8 2019, 3:53 PM
In D18021#389167, @apol wrote:

Good catch!

Should this land on master or 5.3 and then merge?

kfunk added a subscriber: kfunk.Jan 9 2019, 8:42 AM

5.3 only please. Someone else (or even you) can merge it into master afterwards.

This revision was automatically updated to reflect the committed changes.