Shortcut to seek/scrub audio files
ClosedPublic

Authored by ashwind on Jan 6 2019, 4:58 PM.

Details

Summary

Assigned Shift+Left/Right keys as shortcut to seek/scrub audio files (by 10 secs). Having shortcuts to seek/scrub is a good to have feature besides using the mouse.
The patch was in response to the bug 397523 which mentions to use Alt+Left/Right keys. But, as Alt+Left keys are used by ViewNavigation.qml Shift+Left/Right keys were assigned as shortcuts.
As far as fast forwarding is concerned, Elisa doesn't support it yet. So, no shortcuts were introduced.

BUG: 397523
FIXED-IN: elisa 0.3.80

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
ashwind requested review of this revision.Jan 6 2019, 4:58 PM
ashwind created this revision.
ngraham accepted this revision.Jan 7 2019, 12:26 AM
ngraham added a reviewer: Elisa.
ngraham added a subscriber: ngraham.

Very cool!!! Works great for me.

This revision is now accepted and ready to land.Jan 7 2019, 12:26 AM
mgallien requested changes to this revision.Jan 8 2019, 4:30 PM
mgallien added a subscriber: mgallien.

Thanks for your patch.
In order to better integrate it in the application, it would need to be configurable like other existing shortcuts. In order to do that, you can look at the ElisaApplication class.

This revision now requires changes to proceed.Jan 8 2019, 4:30 PM

Oops, I should have realized that!

BTW @mgallien, it's off-topic for this patch, but I wanted to express my happiness over how good Elisa is these days. It's becoming really excellent. The full-screen view is so beautiful and compelling! I plan to contribute a lot in 2019. Once we get https://bugs.kde.org/show_bug.cgi?id=401969, I'm ditching Lollypop and moving to it full-time.

Sorry, I will look into it. ๐Ÿ˜•๐Ÿ˜•

ashwind updated this revision to Diff 49044.Jan 9 2019, 6:26 AM

Well, I made the shortcuts configurable.

mgallien accepted this revision.Jan 9 2019, 9:16 PM

Nice work. Thanks for your help.

This revision is now accepted and ready to land.Jan 9 2019, 9:16 PM

Oops, I should have realized that!

BTW @mgallien, it's off-topic for this patch, but I wanted to express my happiness over how good Elisa is these days. It's becoming really excellent. The full-screen view is so beautiful and compelling! I plan to contribute a lot in 2019. Once we get https://bugs.kde.org/show_bug.cgi?id=401969, I'm ditching Lollypop and moving to it full-time.

@ngraham Thanks a lot for your comment. 6 months ago, I was wondering if it was worth pursuing the project. Now that I have been able to improve and clean a few things, I am much more positive about the future.

Nice work. Thanks for your help.

I forgot to ask if I should land the patch for you or if you have a developer account?

I don't have a developer account. Please land it for me.
Actually, I am new to KDE and don't know about Developer Account. I will sign up for one.

I don't have a developer account. Please land it for me.
Actually, I am new to KDE and don't know about Developer Account. I will sign up for one.

Usually, it is asked to have done several contributions before asking a developer account.

You will also need to put the name of a sponsor. You need to put the name of a developer that has worked with you. I will be happy to help you on that process.

Thank you, @mgallien. I will apply for one after sometime then.

In the meantime, @ashwind, we will need you to provide your full name and email address so we can land this patch with the correct authorship information.

Name: Ashwin Dhakaita
Email: ashwingpdhakaita@gmail.com

Thanks! I'll let @mgallien land this for you when he's ready.

This revision was automatically updated to reflect the committed changes.