With this option is the cursor not moved to the mouse position prior to
paste by middle click
BUG: 363492
dhaumann |
KTextEditor |
With this option is the cursor not moved to the mouse position prior to
paste by middle click
BUG: 363492
Lint Skipped |
Unit Tests Skipped |
Good patch, I think this can go in.
@ngraham: You as native English speaker, is the wording in the dialog ok?
Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set.
A look at that bug report may give more hints/ideas
Hm, didn't you switch the meaning from "Paste by mouse at cursor position" to "Paste clipboard contents at mouse cursor location"? My point is "paste ...at mouse cursor location" is the current behavior, since paste via middle mouse button moves the text cursor position. I thought when the checkbox is checked, the text cursor should NOT move.
I hope you mean @ngraham :-) I just typed overslept what he wrote...yes he has. Before I only kill that "mouse" I like to ask the native speaker if "caret" fit better.
Edit: Now I have "Paste clipboard contents at cursor location"
Hmm, maybe I misunderstood the feature then, sorry!
In cases where there are two binary options but both are semi-confusing, or when one option does not necessarily imply its inverse, radio buttons or a combobox are ideal because then you can make both choices very clear. For example:
Paste using mouse inserts text: (0) At insertion point ( ) At mouse cursor's location
I agree, it's on the first sight pretty clear. But then can you force this "style" for every bool option. In the above linked pic is this obviously only used for Normal vs Vi-Mode [1]
A drawback of that "style" may that you can't say for sure "which is what" in sense of true/false. When you like to change an option by some config file or command, what is to give? [2]
Or what if you like to add an short cut and menu option for this?
With that in mind looks a checkbox not so bad.
[1] Should it be a string setting, too bad, sorry
[2] Well, you have then the key(word) which is typically a short version of the text shown at the checkbox.
To avoid further comments I like to add that I don't like to do the requested change. Please improve it later, if needed.
I can live with the checkbox, too, as the first iteration, but I think you need to change the text in the UI file, atm there is still that "mouse cursor position", should it no be "cursor position"?
Sure, can do it. Which one have it to be ?