test to fix cpp indenter
AbandonedPublic

Authored by cullmann on Jan 5 2019, 8:29 PM.

Details

Reviewers
dhaumann
carewolf
Group Reviewers
Frameworks
Summary

cppstyle indenter is broken with Qt 5.12

this commit shall not be applied as is, I don't get why the null check does no longer work

Test Plan

make test works again with this patch

Diff Detail

Repository
R39 KTextEditor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6685
Build 6703: arc lint + arc unit
cullmann created this revision.Jan 5 2019, 8:29 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 5 2019, 8:29 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Jan 5 2019, 8:29 PM

Hi ;=)

I have some dumb javascript / QJSEngine question:

With Qt 5.12, the regex above

var r = /^(\s*)(([\)\]}]?\s*)*([\)\]]\s*))?;/.exec(prevString);

executes successfully on a "prevString" containing

' ok'

I am a bit confused, why.
The ";" at the end of the regex is not optional, why do I get a non-null r?
Funny enough, the full capture r[0] is empty.

I c reated a Qt bug, I still think this is some regression.

https://bugreports.qt.io/browse/QTBUG-72879

cullmann abandoned this revision.Jan 8 2019, 4:59 PM

See

https://codereview.qt-project.org/#/c/249358/

There will be a fix in Qt (perhaps 5.12.1)