Differential D17995

Add a line to remember file paths when uploading title clips
AbandonedPublic
Actions

Authored by akhilkgangadharan on Jan 5 2019, 6:45 PM.

Details

Reviewers
mardelle
Summary

BUG: T9905
Update variable m_projectTitlePath with user selected directory when the user tries to load title clips from outside the default directory.

Diff Detail

Repository
R158 Kdenlive
Branch
branch2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6681
Build 6699: arc lint + arc unit
akhilkgangadharan requested review of this revision.Jan 5 2019, 6:45 PM
akhilkgangadharan created this revision.
emohr added a comment.Jan 5 2019, 7:05 PM

Hi Akhilkgangadharan. I'm not a coder. Please add Jean-Baptiste Mardelle as reviewer. Thanks.

akhilkgangadharan added a comment.Jan 5 2019, 7:08 PM

Thanks and sorry for the trouble emohr.

akhilkgangadharan edited reviewers, added: mardelle; removed: emohr.Jan 5 2019, 7:10 PM
mardelle added a comment.Jan 6 2019, 11:54 AM

Thanks for this contribution. To convert an url to a string, it is recommended to use toLocalFile() instead of toString() .
Also, the m_projectTitlePath variable is local to the titleWidget, so it is lost as soon as you close the title widget. To work around that, I used a KDE class that was designed to store paths for file dialogs: KRecentDirs::dir(QStringLiteral(":KdenliveProjectsTitles"));

I just pushed a complete fix for this issue: https://phabricator.kde.org/R158:c6adbe259e129588dad6c4229b5e60de62e3be77

akhilkgangadharan abandoned this revision.Jan 6 2019, 3:56 PM

Thanks for reviewing!
I didn't think of storing the path as I thought it wouldn't be needed but now thinking about it, it is required :)

Thanks for the suggestions, I'll abandon this revision.

Revision Contents
Changeset List

PathPackages
Msrc/titler/titlewidget.cpp (3 lines)

Diff 48758

View Options

src/titler/titlewidget.cpp

Loading...