Differential D17978

QuickOpenSession: Indicate clearly the active session
ClosedPublic
Actions

Authored by loh.tar on Jan 5 2019, 5:59 AM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R40:f740df010c50: QuickOpenSession: Indicate clearly the active session
Test Plan

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Jan 5 2019, 5:59 AM
Restricted Application added a project: Kate. · View Herald TranscriptJan 5 2019, 5:59 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Jan 5 2019, 5:59 AM

This patch is somehow a leftover from early days.
Should you think to remove the current active session is a bad idea, let us them at least disable.

dhaumann added a subscriber: dhaumann.Jan 5 2019, 12:53 PM

I would prefer to not hide it since it's confusing. Either gray out the session by calling action ->setEnabled(false), or mark it as active by e.g. adding a '*' or similar to the name.

In any case, using the range based for loop is certainly bette.

loh.tar updated this revision to Diff 48738.Jan 5 2019, 3:00 PM
loh.tar retitled this revision from QuickOpenSession: Don't offer the already active session to QuickOpenSession: Indicate clearly the active session .
loh.tar edited the summary of this revision. (Show Details)
loh.tar edited the test plan for this revision. (Show Details)

Make actions checkable. I think you also prefer this to an "extra star solution".

Thanks for your kindly words elsewhere, Dominik :-)

cullmann accepted this revision.Jan 8 2019, 4:47 PM
cullmann added a subscriber: cullmann.

I think this is a good idea, thanks!

This revision is now accepted and ready to land.Jan 8 2019, 4:47 PM
Closed by commit R40:f740df010c50: QuickOpenSession: Indicate clearly the active session (authored by loh.tar, committed by cullmann). · Explain WhyJan 8 2019, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48738

View Options

kate/session/katesessionsaction.cpp

Loading...