Improve reliability and semantic correctless of dupe test
AbandonedPublic

Authored by ngraham on Sat, Jan 5, 4:12 AM.

Details

Reviewers
ndavis
GB_2
Group Reviewers
Breeze
Summary

This patch makes the dupe test only compare the actual icon directories, not everything in the target's build directory. This eliminates false positives and makes it run faster.

Test Plan

ctest

Diff Detail

Repository
R266 Breeze Icons
Branch
dupe-test-reliability (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6658
Build 6676: arc lint + arc unit
ngraham created this revision.Sat, Jan 5, 4:12 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Jan 5, 4:12 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Sat, Jan 5, 4:12 AM
tcanabrava added inline comments.
autotests/dupetest.cpp
87–88

const ref& ?

89

QLatin1Char('/')

Seams to function correctly.

ndavis requested changes to this revision.EditedFri, Jan 18, 7:02 PM

I found an issue.

With the patch, the dupe test does not detect 2 identical files with the same name in different categories. It is able to detect 2 identical files with different names.

How to reproduce:

  1. cp icons/categories/32/applications-internet.svg icons/preferences/32/applications-internet.svg
  2. make && make test

Failed test before patch (includes false positives and true positive):

Passed test after patch (no false positives or true positive):

This revision now requires changes to proceed.Fri, Jan 18, 7:02 PM
ngraham abandoned this revision.Fri, Jan 18, 8:01 PM

Since this is essentially a workaround for doing in-source builds, the obvious superior course of action is for me to the the work to set up some basic infrastructure for painless out-of-source builds. :)