Read pdb path from binary without extra deps
ClosedPublic
Actions

Authored by vonreth on Jan 5 2019, 12:08 AM.

Details

Reviewers

bcooksley
dschmidt

Commits

Repository

R138 Craft

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vonreth requested review of this revision.Jan 5 2019, 12:08 AM

vonreth created this revision.

vonreth added inline comments.

bin/BuildSystem/BuildSystemBase.py
246	can binaries have multiple pdbs?

I've done some research and from what I can tell, having multiple PDB files for a given file is not possible (it's strictly one per dll/exe)

I see above that cache installs are skipped - will we be capturing the PDBs as part of the cache packages?

This revision is now accepted and ready to land.Jan 5 2019, 5:43 AM

Yes pdbs will be part of the cache.

Cool, this can go in then from my perspective :)

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			bin/BuildSystem/BuildSystemBase.py (25 lines)
M			bin/utils.py (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48706	6044133		Jan 5 2019, 12:08 AM	★	★
Diff 2	48732	6044133	R138:b321a4b4b2160fed8ec9d869b8a1415396560978	Jan 5 2019, 12:54 PM	★	★