Add missing Comment in .desktop file
Needs ReviewPublic

Authored by smishipills on Jan 4 2019, 4:56 PM.



BUG: 351944

Diff Detail

R353 KCalc
Lint Skipped
Unit Tests Skipped
smishipills created this revision.Jan 4 2019, 4:56 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJan 4 2019, 4:56 PM
smishipills requested review of this revision.Jan 4 2019, 4:56 PM
elvisangelaccio added inline comments.

Typo: trignometric

Maybe "such as" instead of "which includes", to avoid using "which" twice?

smishipills updated this revision to Diff 48944.Jan 8 2019, 5:04 AM

Added 'such as' to the comment.

cfeck retitled this revision from Missing Comment in desktop file to Add missing Comment in .desktop file.Jan 8 2019, 11:25 PM
cfeck edited the summary of this revision. (Show Details)
cfeck added a reviewer: ngraham.

Needs a native english speaker to review. But I suggest to either shorten it "Calculator which offers many mathematical functions" or add "and" or "or" before the last item in the enumeration.

cfeck added a comment.Jan 8 2019, 11:27 PM

And I think we don't use a full-stop at the end. For the few applications that I have installed, I only see a short "headline".


Calculator offering mathematical functions such as trigonometry, statistics, and logical operations

Even so, maybe that's a bit long...

smishipills updated this revision to Diff 49043.Jan 9 2019, 5:10 AM
smishipills marked an inline comment as done.
ngraham requested changes to this revision.Jan 12 2019, 5:51 PM

Much better. Even so, "which offers" is not grammatically correct English. It should be one of the following:

  • "Calculator that offers mathematical functions"
  • "Calculator offering mathematical functions"
This revision now requires changes to proceed.Jan 12 2019, 5:51 PM