[Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry
ClosedPublic

Authored by GB_2 on Jan 4 2019, 2:35 PM.

Details

Summary

This adds an icon to the "Edit Applications..." menu entry to make it look better.

Test Plan

Open the right click context menu for Kicker or Kickoff

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Jan 4 2019, 2:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2019, 2:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Jan 4 2019, 2:35 PM
davidedmundson accepted this revision.Jan 4 2019, 2:43 PM
This revision is now accepted and ready to land.Jan 4 2019, 2:43 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Jan 5 2019, 5:51 AM

Hmm, this results in the menu having one colored icon and two monochrome icons.

My gut feeling is that if we're going to use KMenuEdit's icon, perhaps we should mention it by name, e.g. "Edit Applications with KMenuEdit".

If we don't want to do that, or we can't because invoking the menu item might actually open some other app instead of KMenuEdit, then the edit-entry icon might be more appropriate.

Thoughts?

GB_2 added a comment.Jan 5 2019, 10:20 AM

Hmm, this results in the menu having one colored icon and two monochrome icons.

My gut feeling is that if we're going to use KMenuEdit's icon, perhaps we should mention it by name, e.g. "Edit Applications with KMenuEdit".

If we don't want to do that, or we can't because invoking the menu item might actually open some other app instead of KMenuEdit, then the edit-entry icon might be more appropriate.

Thoughts?

I just used the same icon that is used here and in some other places for consistency:

Thoughts?

Valid comment.

Lets use this for now, request an icon from the VDG in the actions folder, and then update this when that happens.