Fix static Kirigami (about page etc)
ClosedPublic

Authored by leinir on Jan 4 2019, 1:06 PM.

Details

Summary

Without this patch, if you tried to use the AboutPage component in a static Kirigami app, the QML engine would complain that the file was missing (of course). Further, once that was fixed, the function i18n also does not exist unless you add it, and since everything else in Kirigami uses qsTr, it seems to make sense to use that in AboutPage and UrlButton as well.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Jan 4 2019, 1:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJan 4 2019, 1:06 PM
leinir requested review of this revision.Jan 4 2019, 1:06 PM
mart accepted this revision.Jan 4 2019, 1:27 PM
This revision is now accepted and ready to land.Jan 4 2019, 1:27 PM
This revision was automatically updated to reflect the committed changes.