Details
- Reviewers
sars dhaumann ltoscano - Group Reviewers
KTextEditor
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
How about to change this logging into a warning message in the view? Or will it displayed(?)
I have noticed these while investigating https://bugs.kde.org/show_bug.cgi?id=397956
Adding as a warning message in the view could be another review and needs comments from others first
Also, I do not understand why a console warning is translated: normal users will not see it, and if they do the message is not actionable for them.
Should we perhaps just remove that message and keep the old compat code without any hint here?
I think it doesn't hurt to just have the few extra checks "forever".
Fine by me regarding the change; I can't answer to the question whether the warning should be localized or not (maybe not), so I'm resigning from the review to not block it
Fixed links got commited in meantime:
commit b64681408d840880c7625543992cc6a75535944a
Author: Grzegorz Szymaszek <gszymaszek@short.pl>
Date: Thu Jan 10 08:42:46 2019 +0100
Use HTTPS, if available, in links visible to users Reviewers: #ktexteditor, dhaumann Reviewed By: #ktexteditor, dhaumann Subscribers: lueck, kwrite-devel, kde-frameworks-devel Tags: #kate, #frameworks Differential Revision: https://phabricator.kde.org/D18148