Uh, does the issue happen only with KF 5.52?

In D17953#386158, @ltoscano wrote:

Uh, does the issue happen only with KF 5.52?

Should be so (it is not tested). Sorry. When I submitted that patch I had tested it for KFind, Kalzium, and KmPlot only. :(

Ok, so does the patched code work also with KF != 5.52? If only 5.52 is bugged and the code is going to work properly with all the other past and future versions, maybe we can just say that 5.52 is broken and be done with that.
(also, could you please point to the issue in 5.52 that was fixed later?)

In D17953#386638, @ltoscano wrote:

Ok, so does the patched code work also with KF != 5.52? If only 5.52 is bugged and the code is going to work properly with all the other past and future versions, maybe we can just say that 5.52 is broken and be done with that.

Yes, it works (or does not work to the same extent as earlier) for versions KF < 5.52 (tested).

(also, could you please point to the issue in 5.52 that was fixed later?)

There is no bug in 5.52 (please read the bug report if you have some time, thanks).

https://bugs.kde.org/show_bug.cgi?id=402837

Long story short:

Before this patch:

1. KF < 5.52, KPat <= 18.12 (tested on Mageia 6, Applications 17.12, KF 5.42):

"Help -> Help with <name of the game>" => Main page of the KPat help in KHelpCenter

2. KF > 5.51, KPat <= 18.12 (tested on Mageia 7, Applications 18.12, KF 5.53):

"Help -> Help with <name of the game>" => Error message ("Could not find filename <name of the game>.html in /usr/share/doc/HTML/en//kpat/<name of the game>.html")

After this patch:

1. KF < 5.52, KPat <= 18.12 (tested on Mageia 6, Applications 17.12, KF 5.42):

"Help -> Help with <name of the game>" => Main page of the KPat help in KHelpCenter

2. KF > 5.51, KPat <= 18.12 (tested on Mageia 7, Applications 18.12, KF 5.53):

"Help -> Help with <name of the game>" => KHelpCenter opens the help section for the <name of the game>.

Thanks again for reading this.