Differential D17944

[effects/slidingpopups] Port away from deprecated EffectWindow::desktop
ClosedPublic
Actions

Authored by zzag on Jan 3 2019, 4:04 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:1084f162aa3d: [effects/slidingpopups] Port away from deprecated EffectWindow::desktop
Summary

If a window is not on the current virtual desktop, then it won't be
painted/slided. Thus, we can replace EffectWindow::desktop by
EffectsHandler::currentDesktop.

Test Plan

The effect still works correctly on both X11 and Wayland.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jan 3 2019, 4:04 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 3 2019, 4:04 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 3 2019, 4:04 PM
davidedmundson accepted this revision.Jan 3 2019, 4:08 PM
This revision is now accepted and ready to land.Jan 3 2019, 4:08 PM
Closed by commit R108:1084f162aa3d: [effects/slidingpopups] Port away from deprecated EffectWindow::desktop (authored by zzag). · Explain WhyJan 3 2019, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48607

View Options

effects/slidingpopups/slidingpopups.cpp

Loading...