[effects/slideback] Port away from deprecated EffectWindow::desktop
ClosedPublic

Authored by davidedmundson on Jan 3 2019, 3:35 PM.

Details

Summary

Not only does the function windowsShareDesktop become a lot more complex
with the new desktop cardinality comparing if they share any desktop
isn't actually what we want.

If I have 2 windows on desktop 1 and the lower stacked window is also on
desktop 2, when I switch desktops the focus will change, but we don't
want to animate anything here as on this dekstop it has nothing to slide
in front of.

Instead this patch simply checks both windows are on the current
desktop.

Test Plan

Loaded a few windows. Some on one, some on more.
Before if a window was on desktop 1&2 it wouldn't animate on 2.

Windows now seem to animate when they should and not when they shouldn't.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 3 2019, 3:35 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 3 2019, 3:35 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 3 2019, 3:35 PM
zzag accepted this revision.Jan 3 2019, 3:53 PM
This revision is now accepted and ready to land.Jan 3 2019, 3:53 PM
This revision was automatically updated to reflect the committed changes.