- AtCore::initSerial => AtCore::newConnection
- AtCore now aware of when machine starts and waits for machine to come up before sending any commands.
Details
Details
Connect printer with both autodetect and manual plugin loading.
Diff Detail
Diff Detail
- Repository
- R232 AtCore
- Branch
- connectPrinter
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6678 Build 6696: arc lint + arc unit
Comment Actions
- Work better for grbl / sprinter
- Make loadFirmwarePlugin private
- Disable user interaction with device settings when connected.
| testclient/mainwindow.cpp | ||
|---|---|---|
| 557 | you could move this to a function and pass a bool to it to set those enablers | |
| src/core/atcore.h | ||
|---|---|---|
| 148 | Doxygen complains that "fwPlugin" is an unknown variable which seems to be right when looking into line 153. | |
| src/core/atcore.cpp | ||
|---|---|---|
| 233 | Invert the ir clause, return early, remove else | |
Comment Actions
- Fix Yuri's catch of wrong variable name in doxygen comment
- Honor Tomaz' request to invert logic in waitForPrinterReboot
| src/core/atcore.h | ||
|---|---|---|
| 543 | It's a very minor problem (and not yours, but all AtCore Doxygen docs) but comma lists without spaces look a bit ugly.  Is it possible to add a space after the comma in the final iteration? Thanks. | |
| src/core/atcore.h | ||
|---|---|---|
| 543 | I fixed it for the whole file. Thanks for the catch | |