Differential D17893

Advanced Color Selector: option to hide color selector
ClosedPublic
Actions

Authored by amedonosova on Dec 31 2018, 10:10 PM.

Details

Reviewers

rempt

Group Reviewers

Krita

Commits

R37:52afd0cbfc8e: Advanced Color Selector: option to hide color selector

Summary

I have resurrected the original patch by Ranveer Aggarwal, which enables the user to hide the
color selector part of the docker.

There was one issue with the original: the docker settings button is inside the color selector, therefore when you hide
the selector, the only way to configure the docker is via the main menu, "Settings" -> "Configure Krita". To solve that I have added
a fallback settings button to the docker widget, which appears when the color selector part is hidden.

BUG: 337328

Diff Detail

Repository

R37 Krita

Branch

amedonosova/adv-color-sel-hiding

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6516
Build 6534: arc lint + arc unit

amedonosova created this revision.Dec 31 2018, 10:10 PM

Restricted Application added a reviewer: Krita. · View Herald TranscriptDec 31 2018, 10:10 PM

Restricted Application added a project: Krita. · View Herald Transcript

amedonosova requested review of this revision.Dec 31 2018, 10:10 PM

Harbormaster completed remote builds in B6516: Diff 48466.Dec 31 2018, 10:10 PM

Thanks -- this works fine.

This revision is now accepted and ready to land.Jan 1 2019, 12:08 PM

Closed by commit R37:52afd0cbfc8e: Advanced Color Selector: option to hide color selector (authored by amedonosova). · Explain WhyJan 1 2019, 12:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/dockers/advancedcolorselector/kis_color_selector_container.h (1 line)
M			plugins/dockers/advancedcolorselector/kis_color_selector_container.cpp (23 lines)
M			plugins/dockers/advancedcolorselector/kis_color_selector_ng_docker_widget.h (8 lines)
M			plugins/dockers/advancedcolorselector/kis_color_selector_ng_docker_widget.cpp (72 lines)
M			plugins/dockers/advancedcolorselector/kis_color_selector_settings.cpp (6 lines)
M			plugins/dockers/advancedcolorselector/wdg_color_selector_settings.ui (500 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48466	6b6758b		Dec 31 2018, 10:10 PM	★	★
Diff 2	48470	6b6758b	R37:52afd0cbfc8e23d1b4c9f519356dbe847fc2a890	Jan 1 2019, 12:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
28e3fabdb840	e1e94c68bea5	38d09ee57647	Anna Medonosova	Advanced Col.Sel: fallback settings button if color selector is hidden	Dec 31 2018, 9:58 PM
38d09ee57647	7c06e9c8df2a	45caf28bdd84	Anna Medonosova	Advanced Col.Sel: hide gamut masking toolbar when selector is hidden	Dec 30 2018, 9:34 PM
45caf28bdd84	592caa1ce736	6b6758bb37da	Anna Medonosova	Advanced color selector: option to show only shade selector (Show More…)	Dec 30 2018, 8:46 PM