Inform user when Baud Maybe wrong
ClosedPublic

Authored by rizzitello on Dec 31 2018, 4:54 PM.

Details

Summary
  • Add new atcoreMessage on connection saying what plunin was loaded
  • Abort connection attempts taking longer then 20 seconds. Inform the user to check settings and retry.
Test Plan

Open test client try to connect with wrong baud. Wait 20 Seconds View message.

Diff Detail

Repository
R232 AtCore
Branch
cleanerConnect
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6677
Build 6695: arc lint + arc unit
rizzitello requested review of this revision.Dec 31 2018, 4:54 PM
rizzitello created this revision.
rizzitello edited the test plan for this revision. (Show Details)Dec 31 2018, 4:55 PM
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
yurchor added inline comments.
testclient/mainwindow.cpp
64

Can it be "seconds" (with small "s")? Thanks.

rizzitello updated this revision to Diff 48460.Dec 31 2018, 6:08 PM
rizzitello edited the test plan for this revision. (Show Details)
  • Yuri's suggestion.
rizzitello marked an inline comment as done.Dec 31 2018, 6:09 PM
laysrodrigues accepted this revision.Jan 1 2019, 12:20 PM
This revision is now accepted and ready to land.Jan 1 2019, 12:20 PM
rizzitello updated this revision to Diff 48472.Jan 1 2019, 1:23 PM
  • Place new code with connection docks other code
rizzitello updated this revision to Diff 48543.Jan 2 2019, 3:57 PM
  • remove atcore changes not needed here
tcanabrava accepted this revision.Jan 5 2019, 5:25 PM

Why you like new so much

rizzitello closed this revision.Jan 5 2019, 5:30 PM